Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81453?usp=email )
Change subject: arch/x86: Remove blank lines before '}' and after '{' ......................................................................
arch/x86: Remove blank lines before '}' and after '{'
Change-Id: I1bb4a052a4e74850660944b687c21e817eb437b2 Signed-off-by: Elyes Haouas ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/81453 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai ericllai@google.com Reviewed-by: Jérémy Compostella jeremy.compostella@intel.com --- M src/arch/x86/exception.c M src/arch/x86/include/arch/cpu.h M src/arch/x86/include/arch/smp/spinlock.h M src/arch/x86/ioapic.c M src/arch/x86/memmove_32.c M src/arch/x86/pirq_routing.c 6 files changed, 0 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved Jérémy Compostella: Looks good to me, but someone else must approve
diff --git a/src/arch/x86/exception.c b/src/arch/x86/exception.c index e2d585f..b8f0583 100644 --- a/src/arch/x86/exception.c +++ b/src/arch/x86/exception.c @@ -369,7 +369,6 @@ stub_flush();
} while ((stub_getc() & 0x7f) != '+'); - } #endif /* CONFIG_GDB_STUB */
diff --git a/src/arch/x86/include/arch/cpu.h b/src/arch/x86/include/arch/cpu.h index cfffac0..430d1de 100644 --- a/src/arch/x86/include/arch/cpu.h +++ b/src/arch/x86/include/arch/cpu.h @@ -213,7 +213,6 @@ c->x86 += (tfms >> 20) & 0xff; if (c->x86 >= 0x6) c->x86_model += ((tfms >> 16) & 0xF) << 4; - }
/* REP NOP (PAUSE) is a good thing to insert into busy-wait loops. */ diff --git a/src/arch/x86/include/arch/smp/spinlock.h b/src/arch/x86/include/arch/smp/spinlock.h index cb25531..3819c8f 100644 --- a/src/arch/x86/include/arch/smp/spinlock.h +++ b/src/arch/x86/include/arch/smp/spinlock.h @@ -55,7 +55,6 @@
/* Switching contexts while holding a spinlock will lead to deadlocks */ thread_coop_disable(); - }
static __always_inline void spin_unlock(spinlock_t *lock) diff --git a/src/arch/x86/ioapic.c b/src/arch/x86/ioapic.c index 863317f..5bb2adb5 100644 --- a/src/arch/x86/ioapic.c +++ b/src/arch/x86/ioapic.c @@ -140,7 +140,6 @@ for (i = 0; i < 3; i++) printk(BIOS_SPEW, " reg 0x%04x: 0x%08x\n", i, io_apic_read(ioapic_base, i)); - }
u8 get_ioapic_id(uintptr_t ioapic_base) diff --git a/src/arch/x86/memmove_32.c b/src/arch/x86/memmove_32.c index 387a77e..7c2529d 100644 --- a/src/arch/x86/memmove_32.c +++ b/src/arch/x86/memmove_32.c @@ -196,5 +196,4 @@ : "memory");
return ret; - } diff --git a/src/arch/x86/pirq_routing.c b/src/arch/x86/pirq_routing.c index 7244536..e6f3b80 100644 --- a/src/arch/x86/pirq_routing.c +++ b/src/arch/x86/pirq_routing.c @@ -125,7 +125,6 @@
/* Set PCI IRQs. */ for (i = 0; i < num_entries; i++) { - u8 bus = pirq_tbl->slots[i].bus; u8 devfn = pirq_tbl->slots[i].devfn;
@@ -133,7 +132,6 @@ devfn >> 3, pirq_tbl->slots[i].slot);
for (intx = 0; intx < MAX_INTX_ENTRIES; intx++) { - int link = pirq_tbl->slots[i].irq[intx].link; int bitmap = pirq_tbl->slots[i].irq[intx].bitmap; int irq = 0; @@ -142,7 +140,6 @@ 'A' + intx, link, bitmap);
if (!bitmap || !link || link > CONFIG_MAX_PIRQ_LINKS) { - printk(BIOS_DEBUG, "not routed\n"); irq_slot[intx] = irq; continue;