Attention is currently required from: Filip Lewiński, Jérémy Compostella, Krystian Hebel, Michał Kopeć, Michał Żygowski, Paul Menzel.
Shuo Liu has posted comments on this change by Filip Lewiński. ( https://review.coreboot.org/c/coreboot/+/82696?usp=email )
Change subject: cpu/x86/mp_init: Add code to restart APs
......................................................................
Patch Set 12: Code-Review+1
(1 comment)
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/82696/comment/4fa7180e_390600a3?usp... :
PS7, Line 1215: printk(BIOS_DEBUG, "%d/%d eventually checked in?\n",
@coreboot.org@gmail. […]
Not sure if we can remove the mdelay in both here and mp_init (maybe in a separate patch) since in start_aps, there is already waits for AP to checkin.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82696?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ief2a7629d3075de29b363d05330e3a76cef48971
Gerrit-Change-Number: 82696
Gerrit-PatchSet: 12
Gerrit-Owner: Filip Lewiński
filip.lewinski@3mdeb.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
miczyg94@gmail.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: coreboot org
coreboot.org@gmail.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Filip Lewiński
filip.lewinski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Żygowski
miczyg94@gmail.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Mon, 07 Apr 2025 06:40:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: coreboot org
coreboot.org@gmail.com
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Filip Lewiński
filip.lewinski@3mdeb.com