Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45952 )
Change subject: soc/intel/common: add Kconfig to enable/disable the ACPI PM timer
......................................................................
Patch Set 21:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45952/21//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45952/21//COMMIT_MSG@21
PS21, Line 21: Note: On Apollolake USE_PM_ACPI_TIMER gets selected statically to avoid
: confusing the user in menuconfig, where the option is shown due to use
: of the common code for PM Timer emulation. On APL there is not hardware
: PM ACPI Timer, so emulation needs to be always enabled.
:
needs rework, when we decide to hide USE_PM_ACPI_TIMER somehow
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45952
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f607f277eb14f84a7370ffb25a13226e7ccc917
Gerrit-Change-Number: 45952
Gerrit-PatchSet: 21
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 17 Oct 2020 23:17:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment