Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52064 )
Change subject: soc/amd: Make espi_clear_decodes private ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52064/comment/146f2207_f4c074a3 PS1, Line 10: change consolidates the clear logic into one spot. I think it would be good to mention here that this changes the behavior for Picasso since the decodes weren't cleared before. But, that shouldn't really have any impact as decodes are again set up as per the mainboard configuration.
Just thinking out loud: * In case where verstage runs on PSP, verstage clears eSPI decodes and sets up as per mainboard configuration. Once PSP is done, x86 will clear decodes and reconfigure as per mainboard configuration.
* In case where verstage does not run on PSP, x86 will clear decodes and reconfigure as per mainboard configuration.
In both cases, the corresponding first stage on the PSP/x86 sets things up correctly before using it.
-
Furquan Shaikh (Code Review)