Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held.
Patch set 1:Code-Review +2
View Change
1 comment:
Commit Message:
Patch Set #1, Line 10: change consolidates the clear logic into one spot.
I think it would be good to mention here that this changes the behavior for Picasso since the decodes weren't cleared before. But, that shouldn't really have any impact as decodes are again set up as per the mainboard configuration.
Just thinking out loud:
- In case where verstage runs on PSP, verstage clears eSPI decodes and sets up as per mainboard configuration. Once PSP is done, x86 will clear decodes and reconfigure as per mainboard configuration.
- In case where verstage does not run on PSP, x86 will clear decodes and reconfigure as per mainboard configuration.
In both cases, the corresponding first stage on the PSP/x86 sets things up correctly before using it.
To view, visit change 52064. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic57689e50febd29796d8ac8d99c81e41fee5b41c
Gerrit-Change-Number: 52064
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Attention: Raul Rangel <rrangel@chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Comment-Date: Fri, 02 Apr 2021 20:45:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment