Attention is currently required from: Arthur Heymans, Jonathan Zhang, Lance Zhao, Martin L Roth, Rocky Phagura, Tim Wawrzynczak.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77416?usp=email )
Change subject: acpi: Move EINJ code to vendorcode/ocp
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/77416/comment/d5b56a48_f4abd0f2 :
PS3, Line 7: acpi: Move EINJ code to vendorcode/ocp
They *could* stay, but there's no reason to keep them if we're moving everything else out. […]
Breaking apart the header seems fine IMO, but I wouldn't consider things written from the ACPI spec to be akin to "random tables". How about moving `acpi_einj_smi_t` out, but keep the #defines and tables like `acpi_einj_action_table_t` in `include/acpi/`?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77416?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2e91b0730cf3fcef0c54c513181c973bfe18bacf
Gerrit-Change-Number: 77416
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Rocky Phagura
rphagura@fb.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Rocky Phagura
rphagura@fb.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 20 Nov 2023 00:05:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment