Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45872 )
Change subject: security/intel/stm: Fix size_t printf format error ......................................................................
security/intel/stm: Fix size_t printf format error
This sort-of reverts commit 075df92298fe3bb0ef04233395effe668c4a5550 and fixes the underlying issue. The printf format string type/length specifier for a size_t type is z.
Change-Id: I897380060f7ea09700f77beb81d52c18a45326ad Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/security/intel/stm/SmmStm.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/45872/1
diff --git a/src/security/intel/stm/SmmStm.c b/src/security/intel/stm/SmmStm.c index 00490cf..e2fab0c 100644 --- a/src/security/intel/stm/SmmStm.c +++ b/src/security/intel/stm/SmmStm.c @@ -477,7 +477,7 @@ return -1; // INVALID_PARAMETER;
resource_size = get_resource_size(resource_list, num_entries); - printk(BIOS_DEBUG, "STM: ResourceSize - 0x%08x\n", (int) resource_size); + printk(BIOS_DEBUG, "STM: ResourceSize - 0x%08zx\n", resource_size); if (resource_size == 0) return -1; // INVALID_PARAMETER;
Eugene Myers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45872 )
Change subject: security/intel/stm: Fix size_t printf format error ......................................................................
Patch Set 1: Code-Review+1
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45872 )
Change subject: security/intel/stm: Fix size_t printf format error ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45872 )
Change subject: security/intel/stm: Fix size_t printf format error ......................................................................
Patch Set 1: Code-Review+1
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45872 )
Change subject: security/intel/stm: Fix size_t printf format error ......................................................................
security/intel/stm: Fix size_t printf format error
This sort-of reverts commit 075df92298fe3bb0ef04233395effe668c4a5550 and fixes the underlying issue. The printf format string type/length specifier for a size_t type is z.
Change-Id: I897380060f7ea09700f77beb81d52c18a45326ad Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/45872 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eugene Myers cedarhouse1@comcast.net Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/security/intel/stm/SmmStm.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve HAOUAS Elyes: Looks good to me, approved Eugene Myers: Looks good to me, but someone else must approve
diff --git a/src/security/intel/stm/SmmStm.c b/src/security/intel/stm/SmmStm.c index 00490cf..e2fab0c 100644 --- a/src/security/intel/stm/SmmStm.c +++ b/src/security/intel/stm/SmmStm.c @@ -477,7 +477,7 @@ return -1; // INVALID_PARAMETER;
resource_size = get_resource_size(resource_list, num_entries); - printk(BIOS_DEBUG, "STM: ResourceSize - 0x%08x\n", (int) resource_size); + printk(BIOS_DEBUG, "STM: ResourceSize - 0x%08zx\n", resource_size); if (resource_size == 0) return -1; // INVALID_PARAMETER;
-
Eugene Myers (Code Review) -
Felix Held (Code Review)
-
HAOUAS Elyes (Code Review)
-
Paul Menzel (Code Review)