Attention is currently required from: Subrata Banik, Matt DeVillier, Boris Mittelberg.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74603 )
Change subject: [WIP] mb/google/link: Use chromeec_smi_sleep()
......................................................................
Patch Set 2:
(1 comment)
File src/ec/google/chromeec/smihandler.c:
https://review.coreboot.org/c/coreboot/+/74603/comment/1e9ca98f_76083df8
PS1, Line 67: ACPI_S4
It's intentional here in the sense it should be discussed. […]
Let's use CB:74823 for this discussion.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74603
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54c7d7455a6737f731c65e57c91b6457643c7cb2
Gerrit-Change-Number: 74603
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Fri, 28 Apr 2023 00:33:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment