Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/53997 )
Change subject: Makefile: Don't run genbuild_h if not doing a build ......................................................................
Makefile: Don't run genbuild_h if not doing a build
genbuild_h was being run on every make invocation - clean, distclean, etc. to get the source date epoch value. This value isn't used unless a build is being done, so don't run it on non-compile make invocations.
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: I2afc0affc17116e0db849ea968474bc19dbb0ae1 Reviewed-on: https://review.coreboot.org/c/coreboot/+/53997 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Patrick Georgi pgeorgi@google.com --- M Makefile 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/Makefile b/Makefile index 02c6288..e25c081 100644 --- a/Makefile +++ b/Makefile @@ -24,7 +24,9 @@ LANG:=C LC_ALL:=C TZ:=UTC0 +ifneq ($(NOCOMPILE),1) SOURCE_DATE_EPOCH := $(shell $(top)/util/genbuild_h/genbuild_h.sh . | sed -n 's/^.define COREBOOT_BUILD_EPOCH>.*"(.*)".*/\1/p') +endif # don't use COREBOOT_EXPORTS to ensure build steps outside the coreboot build system # are reproducible export LANG LC_ALL TZ SOURCE_DATE_EPOCH