Tobias Diedrich has posted comments on this change. ( https://review.coreboot.org/17425 )
Change subject: driver/pc80/tpm: Runtime generate ACPI table for TPM driver
......................................................................
Patch Set 12:
(1 comment)
In ticket #102 [1], it’s claimed that this commit introduced a
regression.
The change-set I6e65b37507c111af1c0c56822327d5497f58f085 also
mentions this commit.
"ACPI Error: [_SB_.PCI0.LPCB] Namespace lookup failure, AE_NOT_FOUND (20160422/dswload-210)"
sounds like the default path _SB.PCI0.LPCB does not match the actual path on the board?
e.g. in https://review.coreboot.org/#/c/18402/ I added the plumbing to make the path correct for AMD SB800 (for pcengines APU1).
This would probably need a similar patch for the affected board or alternatively make the default "_SB.PCI0.LPCB" configurable in Kconfig instead of hardcoded.
--
To view, visit
https://review.coreboot.org/17425
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70896e5874c24f17fca0c48b138ad4917b273f5b
Gerrit-PatchSet: 12
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Naresh Solanki
naresh.solanki@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tobias Diedrich
ranma+coreboot@tdiedrich.de
Gerrit-Reviewer: Vladimir Serbinenko
phcoder@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No