Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48373 )
Change subject: mb/clevo/l140cu: Remove unnecessary device declarations ......................................................................
Patch Set 2: -Code-Review
(2 comments)
https://review.coreboot.org/c/coreboot/+/48373/2/src/mainboard/clevo/cml-u/v... File src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48373/2/src/mainboard/clevo/cml-u/v... PS2, Line 135: device pci 00.0 on end # x1 Card reader
this one is on-board, thus keep it
setting subsystem ids and smbios depend on the flag `.on_mainboard`, which sconfig sets depending on presence of a device -> keep this one
https://review.coreboot.org/c/coreboot/+/48373/2/src/mainboard/clevo/cml-u/v... PS2, Line 135: # x1 Card reader PcieRpEnable will vanish; maybe add the comment above or as # PCI Express Port 6 (x1 Card reader)?
-
Michael Niewöhner (Code Review)