Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23705 )
Change subject: soc/intel/skylake: Use common EMMC block code ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/23705/3/src/soc/intel/skylake/Kconfig File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/#/c/23705/3/src/soc/intel/skylake/Kconfig@63 PS3, Line 63: select SOC_INTEL_COMMON_BLOCK_EMMC_INIT_OVER_AP I'm not sure we should be doing this by default. It should be a choice by the mainboard at the very least.
https://review.coreboot.org/#/c/23705/3/src/soc/intel/skylake/include/soc/io... File src/soc/intel/skylake/include/soc/iomap.h:
https://review.coreboot.org/#/c/23705/3/src/soc/intel/skylake/include/soc/io... PS3, Line 79: #define EMMC_BASE_ADDRESS 0xfe601000 How is this fixed? I thought the emmc controller is a normal pci device that gets resources assigned to it.
-
Aaron Durbin (Code Review)