HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34267 )
Change subject: soc/intel/denverton_ns: Add missing typedef gpio_t ......................................................................
soc/intel/denverton_ns: Add missing typedef gpio_t
<soc/gpio.h> must typedef a gpio_t that fits in 32 bits.
Change-Id: I9dc90201eb1a344a9e9b379fe08a2af7807026ed Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/denverton_ns/include/soc/gpio.h 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/34267/1
diff --git a/src/soc/intel/denverton_ns/include/soc/gpio.h b/src/soc/intel/denverton_ns/include/soc/gpio.h index 082de21..860b95b 100644 --- a/src/soc/intel/denverton_ns/include/soc/gpio.h +++ b/src/soc/intel/denverton_ns/include/soc/gpio.h @@ -49,4 +49,7 @@ #include <intelblocks/gpio.h>/* intelblocks/gpio.h depends on definitions in lines above and soc/gpio_defs.h */
+/* <soc/gpio.h> must typedef a gpio_t that fits in 32 bits. */ +typedef uint32_t gpio_t; + #endif /* _SOC_DENVERTON_NS_GPIO_H_ */
Hello Patrick Rudolph, Vanny E, build bot (Jenkins), David Guckian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34267
to look at the new patch set (#2).
Change subject: soc/intel/denverton_ns: Add missing typedef gpio_t ......................................................................
soc/intel/denverton_ns: Add missing typedef gpio_t
<soc/gpio.h> must typedef a gpio_t that fits in 32 bits.
Change-Id: I9dc90201eb1a344a9e9b379fe08a2af7807026ed Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/denverton_ns/include/soc/gpio.h 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/34267/2
David Guckian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34267 )
Change subject: soc/intel/denverton_ns: Add missing typedef gpio_t ......................................................................
Patch Set 2: Code-Review+1
Vanny E has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34267 )
Change subject: soc/intel/denverton_ns: Add missing typedef gpio_t ......................................................................
Patch Set 2: Code-Review+1
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34267 )
Change subject: soc/intel/denverton_ns: Add missing typedef gpio_t ......................................................................
Abandoned
-
David Guckian (Code Review) -
HAOUAS Elyes (Code Review)
-
Vanny E (Code Review)