Attention is currently required from: Robert Zieba, Christian Walter, Felix Held.
Konrad Adamczyk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74474 )
Change subject: util: Use common ARRAY_SIZE define
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
i'm not sure either and i forgot to bring that up in the last coreboot leadership meeting :/ added t […]
Thanks for update, waiting for another one then after leadership meeting on May 31st.
As you've pointed out, `util/` and `src/` are not separated submodules and AFAIC there's a bunch of `util/` tools that are using `commonlib` from `src/` heavily, few examples below: https://github.com/coreboot/coreboot/blob/master/util/cbfstool/cbfstool.c#L1...
https://github.com/coreboot/coreboot/blob/master/util/cbfstool/common.h#L12
https://github.com/coreboot/coreboot/blob/master/util/amdfwtool/amdfwtool.h#...
If coreboot is about to move out of the `util/` and `src/` dependency, I believe existing dependencies shall be addressed as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74474
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29b776586b4f0548d4026b2ac77095791fc9f3a3
Gerrit-Change-Number: 74474
Gerrit-PatchSet: 3
Gerrit-Owner: Konrad Adamczyk
konrada@google.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Grzegorz Bernacki
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 22 May 2023 06:21:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Konrad Adamczyk
konrada@google.com
Comment-In-Reply-To: Robert Zieba
robertzieba@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment