Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50239 )
Change subject: soc/amd/cezanne: populate some FSP-M UPDs
......................................................................
Patch Set 3:
(2 comments)
File src/soc/amd/cezanne/romstage.c:
https://review.coreboot.org/c/coreboot/+/50239/comment/cf484666_d43faae0
PS2, Line 19: 1
ah, DRIVERS_UART_8250MEM and DRIVERS_UART_8250MEM_32 only get selected together, so this is indeed f […]
Done
https://review.coreboot.org/c/coreboot/+/50239/comment/dd383286_68289e74
PS2, Line 19: serial_port_stride
Do we need to pass in the baud clock? Or does FSP-M assume the baud rate has already been set?
added that to match what picasso does for now; since during bringup we'll only use the internal uart the defaults were sane though. refclk, baudrate and stride will probably be removed after the initial bringup is done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50239
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81a812662f921d0bf8d436238d338b6a1fa6a9ee
Gerrit-Change-Number: 50239
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Thu, 04 Feb 2021 01:45:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment