Attention is currently required from: Angel Pons, Nicholas Chin.
Václav Straka has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85825?usp=email )
Change subject: mb/hp: Add Pro 3400 ......................................................................
Patch Set 11:
(3 comments)
File src/mainboard/hp/pro_3x00_series/Kconfig:
https://review.coreboot.org/c/coreboot/+/85825/comment/98084df0_30d29ac9?usp... : PS11, Line 46: config DRAM_RESET_GATE_GPIO : default 60
That's the default and could be removed
Done
File src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/board_info.txt:
https://review.coreboot.org/c/coreboot/+/85825/comment/74a502c8_4da4e550?usp... : PS11, Line 2: ROM IC: W25Q32BVSIG
I wouldn't list the chip model, not all boards have the same chip model
Done
File src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/board_info.txt:
https://review.coreboot.org/c/coreboot/+/85825/comment/7ec0537b_7c11a075?usp... : PS11, Line 2: ROM IC: W25Q64FVSIG
Same, especially if the docs said something about a different chip model
Done