Change in coreboot[master]: mb/google/guybrush/var/nipperkin: override dxio to turn off WLAN ASPM... - coreboot-gerrit

25 Oct 2021


      Attention is currently required from: Kevin Chiu, Martin Roth, Bhanu Prakash Maiya, Eric Peers, Rob Barnes, Karthik Ramasubramanian.
Matt Papageorge has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58417 )
Change subject: mb/google/guybrush/var/nipperkin: override dxio to turn off WLAN ASPM L1.2/L1.2
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS3:
...
Would anyone else prefer coreboot to not set ASPM enable bits rather relying on FSP? If this patch w […]
If this is indeed a short term w/a and it appears to produce the desired results I suppose I am satisfied with that. But I would feel very uneasy leaving it like this long term.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58417
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic7be523626b0ff6e4b1c66ba6af13b15061ef4cb
Gerrit-Change-Number: 58417
Gerrit-PatchSet: 8
Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Bhanu Prakash Maiya bhanumaiya@google.com
Gerrit-Reviewer: Eric Peers epeers@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Matt Papageorge matthewpapa07@gmail.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Kevin Chiu kevin.chiu.17802@gmail.com
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Bhanu Prakash Maiya bhanumaiya@google.com
Gerrit-Attention: Eric Peers epeers@google.com
Gerrit-Attention: Rob Barnes robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Mon, 25 Oct 2021 19:56:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Chiu kevin.chiu.17802@gmail.com
Comment-In-Reply-To: Matt Papageorge matthewpapa07@gmail.com
Gerrit-MessageType: comment