Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75356?usp=email )
Change subject: soc/sifive: Comment out set but unused variables ......................................................................
soc/sifive: Comment out set but unused variables
The code is supposed to output debug messages but is commented out, so do the same for variables.
Signed-off-by: Arthur Heymans arthur@aheymans.xyz Change-Id: Ief1f9d2175fe1375fe6ac4bb0765b00513321fa6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75356 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Elyes Haouas ehaouas@noos.fr --- M src/soc/sifive/fu540/ux00ddr.h 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: Angel Pons: Looks good to me, but someone else must approve build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved
diff --git a/src/soc/sifive/fu540/ux00ddr.h b/src/soc/sifive/fu540/ux00ddr.h index bf856f3..d468a8e 100644 --- a/src/soc/sifive/fu540/ux00ddr.h +++ b/src/soc/sifive/fu540/ux00ddr.h @@ -148,9 +148,9 @@
size_t ddrphyreg = ahbregaddr + 0x2000;
- uint64_t fails=0; + // uint64_t fails=0; uint32_t slicebase = 0; - uint32_t dq = 0; + // uint32_t dq = 0;
// check errata condition for (uint32_t slice = 0; slice < 8; slice++) { @@ -175,7 +175,7 @@ // print error message on failure if (failc0 || failc1) { //if (fails==0) uart_puts((void*) UART0_CTRL_ADDR, "DDR error in fixing up \n"); - fails |= (1<<dq); + //fails |= (1<<dq); /* char slicelsc = '0'; */ /* char slicemsc = '0'; */ /* slicelsc += (dq % 10); */ @@ -187,7 +187,7 @@ //else uart_puts((void*) UART0_CTRL_ADDR, "D"); //uart_puts((void*) UART0_CTRL_ADDR, "\n"); } - dq++; + //dq++; } } slicebase+=128;