Attention is currently required from: Lance Zhao, Tim Wawrzynczak.
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78334?usp=email )
Change subject: device/device.h: Drop acpi_inject_dsdt ......................................................................
device/device.h: Drop acpi_inject_dsdt
This is now unused in the tree and filling SSDT should always be used.
Signed-off-by: Arthur Heymans arthur@aheymans.xyz Change-Id: Iffefc865901b15fa299931b6ed4c27a9e3a1c330 --- M src/acpi/acpi.c M src/include/device/device.h 2 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/78334/1
diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index 82846fe..0df6c62 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -1293,9 +1293,6 @@ if (CONFIG(CHROMEOS_NVS)) acpi_fill_cnvs();
- for (const struct device *dev = all_devices; dev; dev = dev->next) - if (dev->ops && dev->ops->acpi_inject_dsdt) - dev->ops->acpi_inject_dsdt(dev); current = (unsigned long)acpigen_get_current(); memcpy((char *)current, (char *)dsdt_file + sizeof(acpi_header_t), diff --git a/src/include/device/device.h b/src/include/device/device.h index 6f1d13e..665d420 100644 --- a/src/include/device/device.h +++ b/src/include/device/device.h @@ -59,7 +59,6 @@ unsigned long (*write_acpi_tables)(const struct device *dev, unsigned long start, struct acpi_rsdp *rsdp); void (*acpi_fill_ssdt)(const struct device *dev); - void (*acpi_inject_dsdt)(const struct device *dev); const char *(*acpi_name)(const struct device *dev); /* Returns the optional _HID (Hardware ID) */ const char *(*acpi_hid)(const struct device *dev);