HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43913 )
Change subject: nb/intel/i945/gma.c: Remove extra indentation ......................................................................
nb/intel/i945/gma.c: Remove extra indentation
Change-Id: If48cd055477011cece7921cea462aab176e170fb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/gma.c 1 file changed, 4 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/43913/1
diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c index 929968e..e0009b3 100644 --- a/src/northbridge/intel/i945/gma.c +++ b/src/northbridge/intel/i945/gma.c @@ -360,13 +360,12 @@
set_vbe_mode_info_valid(&edid, pgfx); } else { - vga_misc_write(0x67); + vga_misc_write(0x67);
- write32(mmiobase + DSPCNTR(0), DISPPLANE_SEL_PIPE_B); - write32(mmiobase + VGACNTRL, 0x02c4008e - | VGA_PIPE_B_SELECT); + write32(mmiobase + DSPCNTR(0), DISPPLANE_SEL_PIPE_B); + write32(mmiobase + VGACNTRL, 0x02c4008e | VGA_PIPE_B_SELECT);
- vga_textmode_init(); + vga_textmode_init(); } return 0; }
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43913 )
Change subject: nb/intel/i945/gma.c: Remove extra indentation ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/43913/1/src/northbridge/intel/i945/... File src/northbridge/intel/i945/gma.c:
https://review.coreboot.org/c/coreboot/+/43913/1/src/northbridge/intel/i945/... PS1, Line 366: this shouldn't be a tab
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43913 )
Change subject: nb/intel/i945/gma.c: Remove extra indentation ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43913/1/src/northbridge/intel/i945/... File src/northbridge/intel/i945/gma.c:
https://review.coreboot.org/c/coreboot/+/43913/1/src/northbridge/intel/i945/... PS1, Line 366:
this shouldn't be a tab
you are right. Thx
Hello build bot (Jenkins), Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43913
to look at the new patch set (#2).
Change subject: nb/intel/i945/gma.c: Remove extra indentation ......................................................................
nb/intel/i945/gma.c: Remove extra indentation
Change-Id: If48cd055477011cece7921cea462aab176e170fb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/gma.c 1 file changed, 4 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/43913/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43913 )
Change subject: nb/intel/i945/gma.c: Remove extra indentation ......................................................................
Patch Set 2: Code-Review+2
a
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43913 )
Change subject: nb/intel/i945/gma.c: Remove extra indentation ......................................................................
nb/intel/i945/gma.c: Remove extra indentation
Change-Id: If48cd055477011cece7921cea462aab176e170fb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/43913 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/i945/gma.c 1 file changed, 4 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c index 929968e..a4cdf70 100644 --- a/src/northbridge/intel/i945/gma.c +++ b/src/northbridge/intel/i945/gma.c @@ -360,13 +360,12 @@
set_vbe_mode_info_valid(&edid, pgfx); } else { - vga_misc_write(0x67); + vga_misc_write(0x67);
- write32(mmiobase + DSPCNTR(0), DISPPLANE_SEL_PIPE_B); - write32(mmiobase + VGACNTRL, 0x02c4008e - | VGA_PIPE_B_SELECT); + write32(mmiobase + DSPCNTR(0), DISPPLANE_SEL_PIPE_B); + write32(mmiobase + VGACNTRL, 0x02c4008e | VGA_PIPE_B_SELECT);
- vga_textmode_init(); + vga_textmode_init(); } return 0; }
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)