Attention is currently required from: Andrey Petrov, Arthur Heymans, Chen, Gang C, Christian Walter, Jincheng Li, Johnny Lin, Jérémy Compostella, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Paul Menzel, Ronak Kanabar, Tim Chu.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80579?usp=email )
Change subject: drivers/intel/fsp: Work around multi socket Xeon-SP pipe init bug
......................................................................
Patch Set 4:
(4 comments)
Patchset:
PS4:
Tested in SPR 1S system and failed to boot. Found some places needing to be revised. Our SPR 2S system is not available recent days. Maybe Patrick could help to test on his machine.
File src/arch/x86/car.ld:
https://review.coreboot.org/c/coreboot/+/80579/comment/547ae76b_5ef28c37 :
PS4, Line 15:
To be simple, maybe we could use REGION(fspm_heap ...) here and discard the .car.fspm_heap declaration later. REGION will declare the same set of linker absolute symbols.
https://review.coreboot.org/c/coreboot/+/80579/comment/55a77496_04f3c4b1 :
PS4, Line 118: _fspm_heap = .;
Need to use ABSOLUTE(.) to make sure the symbol value is always a correct constant
File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/c/coreboot/+/80579/comment/30df41fa_d9d92690 :
PS4, Line 175: extern char *_fspm_heap;
Need to use extern car _fspm_heap[] instead to make sure the symbol is instantiated as an immediate number in asm.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80579?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I38a4f4b7470556e528a1672044c31f8bd92887d4
Gerrit-Change-Number: 80579
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Tue, 20 Feb 2024 11:55:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment