Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36586 )
Change subject: sb/intel/common/platform.asl: Remove setting unused GNVS ......................................................................
sb/intel/common/platform.asl: Remove setting unused GNVS
Change-Id: I842af0a0e6435d33759649065b2b5a6f6d35071d Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/southbridge/intel/common/acpi/platform.asl 1 file changed, 0 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/36586/1
diff --git a/src/southbridge/intel/common/acpi/platform.asl b/src/southbridge/intel/common/acpi/platform.asl index ba8091d..03cb625 100644 --- a/src/southbridge/intel/common/acpi/platform.asl +++ b/src/southbridge/intel/common/acpi/platform.asl @@ -71,16 +71,6 @@ Store (2000, OSYS)
If (CondRefOf(_OSI)) { - /* Linux answers _OSI with "True" for a couple of - * Windows version queries. But unlike Windows it - * needs a Video repost, so let's determine whether - * we're running Linux. - */ - - If (_OSI("Linux")) { - Store (1, LINX) - } - If (_OSI("Windows 2001")) { Store (2001, OSYS) }
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36586 )
Change subject: sb/intel/common/platform.asl: Remove setting unused GNVS ......................................................................
Patch Set 1: Code-Review+2
This is worthy of killing with fire
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36586 )
Change subject: sb/intel/common/platform.asl: Remove setting unused GNVS ......................................................................
sb/intel/common/platform.asl: Remove setting unused GNVS
Change-Id: I842af0a0e6435d33759649065b2b5a6f6d35071d Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/36586 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/common/acpi/platform.asl 1 file changed, 0 insertions(+), 10 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/southbridge/intel/common/acpi/platform.asl b/src/southbridge/intel/common/acpi/platform.asl index ba8091d..03cb625 100644 --- a/src/southbridge/intel/common/acpi/platform.asl +++ b/src/southbridge/intel/common/acpi/platform.asl @@ -71,16 +71,6 @@ Store (2000, OSYS)
If (CondRefOf(_OSI)) { - /* Linux answers _OSI with "True" for a couple of - * Windows version queries. But unlike Windows it - * needs a Video repost, so let's determine whether - * we're running Linux. - */ - - If (_OSI("Linux")) { - Store (1, LINX) - } - If (_OSI("Windows 2001")) { Store (2001, OSYS) }
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Patrick Georgi (Code Review)