Change in coreboot[master]: soc/amd/picasso: remove unused AMDFW_OUTSIDE_CBFS Kconfig option
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47890 )
Change subject: soc/amd/picasso: remove unused AMDFW_OUTSIDE_CBFS Kconfig option ......................................................................
soc/amd/picasso: remove unused AMDFW_OUTSIDE_CBFS Kconfig option
The corresponding functionality in the SoC's Makefile.inc was removed in commit ef3395d990bbf1118a8d4e367a986bdbc92b1820
Change-Id: Iba84d9deb155ce314b3a3588781752b83a21486b Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/picasso/Kconfig 1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/47890/1
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index 6fa3664..c3995c8 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -406,14 +406,6 @@
menu "PSP Configuration Options"
-config AMDFW_OUTSIDE_CBFS - bool - default n - help - The AMDFW (PSP) is typically locatable in cbfs. Select this - option to manually attach the generated amdfw.rom outside of - cbfs. The location is selected by the FWM position. - config AMD_FWM_POSITION_INDEX int "Firmware Directory Table location (0 to 5)" range 0 5
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47890 )
Change subject: soc/amd/picasso: remove unused AMDFW_OUTSIDE_CBFS Kconfig option ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47890 )
Change subject: soc/amd/picasso: remove unused AMDFW_OUTSIDE_CBFS Kconfig option ......................................................................
soc/amd/picasso: remove unused AMDFW_OUTSIDE_CBFS Kconfig option
The corresponding functionality in the SoC's Makefile.inc was removed in commit ef3395d990bbf1118a8d4e367a986bdbc92b1820
Change-Id: Iba84d9deb155ce314b3a3588781752b83a21486b Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/47890 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/picasso/Kconfig 1 file changed, 0 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index 6fa3664..c3995c8 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -406,14 +406,6 @@
menu "PSP Configuration Options"
-config AMDFW_OUTSIDE_CBFS - bool - default n - help - The AMDFW (PSP) is typically locatable in cbfs. Select this - option to manually attach the generated amdfw.rom outside of - cbfs. The location is selected by the FWM position. - config AMD_FWM_POSITION_INDEX int "Firmware Directory Table location (0 to 5)" range 0 5
Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47890 )
Change subject: soc/amd/picasso: remove unused AMDFW_OUTSIDE_CBFS Kconfig option ......................................................................
Patch Set 2: Code-Review+1
-
Felix Held (Code Review) -
Jason Glenesk (Code Review)
-
Marshall Dawson (Code Review)