Attention is currently required from: Eric Lai, Ian Feng, Kenny Pan, Nick Vaccaro, Paul Menzel, Shou-Chieh Hsu, Sumeet R Pawnikar.
Rex Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79890?usp=email )
Change subject: mb/google/nissa/var/craaskov: Modify 6W and 15W DPTF parameters
......................................................................
Patch Set 7:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79890/comment/4546d513_5a372df6 :
PS6, Line 8:
Please describe the problem.
Done
https://review.coreboot.org/c/coreboot/+/79890/comment/087a36b1_5c9108f3 :
PS6, Line 9: b:290705146#comment41
I am not allowed to read this comment.
Follow "Project_Craaskov_FW_Thermal_paramters_list_20240104_1.xlsx" to modify 6w/15w DPTF parameters
https://review.coreboot.org/c/coreboot/+/79890/comment/e6b72d05_54832735 :
PS6, Line 10: power(Watts)
Please add a space before the (.
Done
https://review.coreboot.org/c/coreboot/+/79890/comment/5572c9c8_b6783de7 :
PS6, Line 10: change
increase
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79890?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I15fa4b8f7c7088ff56da6493659ae45572913b5a
Gerrit-Change-Number: 79890
Gerrit-PatchSet: 7
Gerrit-Owner: Rex Chou
rex_chou@compal.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Kenny Pan
kennypan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Kenny Pan
kennypan@google.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Comment-Date: Wed, 17 Jan 2024 01:34:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment