Attention is currently required from: Paul Menzel, Angel Pons, Felix Held. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63888 )
Change subject: soc/intel/ehl: Provide function to change PHY-to-MAC IRQ polarity ......................................................................
Patch Set 15:
(6 comments)
File src/soc/intel/elkhartlake/chip.h:
https://review.coreboot.org/c/coreboot/+/63888/comment/74e37dbb_ca70e077 PS14, Line 487: PchTsnPhyIrqEdge
Could we please avoid CamelCase names?
Done
File src/soc/intel/elkhartlake/include/soc/tsn_gbe.h:
https://review.coreboot.org/c/coreboot/+/63888/comment/2f4306ca_f37e8611 PS14, Line 16:
nit: Gerrit says this is a tab?
Done
https://review.coreboot.org/c/coreboot/+/63888/comment/5aad049c_3b9d76d1 PS14, Line 36: int32_t
enum cb_err
Done
File src/soc/intel/elkhartlake/tsn_gbe.c:
https://review.coreboot.org/c/coreboot/+/63888/comment/4c1e90aa_7210b937 PS14, Line 31: int32_t
enum cb_err
Done
https://review.coreboot.org/c/coreboot/+/63888/comment/76c00938_7130c8ba PS14, Line 37: read32((void *)
Also see CB:64398 which I just made, which I made with this commit in mind.
when I use read32p, I get a cast error...
src/soc/intel/elkhartlake/tsn_gbe.c:37:37: error: passing argument 1 of 'read32p' makes integer from pointer without a cast [-Werror=int-conversion] 37 | if (!(read32p((base + TSN_MAC_MDIO_ADR)) & TSN_MAC_GMII_BUSY)) | ~~~~~~^~~~~~~~~~~~~~~~~~~ | | | void *
https://review.coreboot.org/c/coreboot/+/63888/comment/23083d93_5903cdc2 PS14, Line 106: uintptr_t io_mem_base = gbe_tsn_res->base;
Hmmm, using `void *` type for the base address would avoid a bunch of type casts. […]
Done