Attention is currently required from: Alicja Michalska.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80853?usp=email )
Change subject: mb/erying: Add Erying Polestar G613 Pro (TGL-H) ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80853/comment/f208d772_16540378 : PS1, Line 35: haven't enabled singular: hasn’t enabled
or
does not enable
https://review.coreboot.org/c/coreboot/+/80853/comment/a76f7107_aff47b20 : PS1, Line 50: Starting to suspect Intel's FSP might be buggy, as I haven't had those : issues when I initially started working on this project when 4.20 tree : was current. Would be nice if you could bisect in some way.
Patchset:
PS1: Welcome and thank you for this awesome contribution!
The bot failure is:
File src/mainboard/erying/tgl/devicetree.cb has one or more executable bits set in the file permissions. File src/mainboard/erying/tgl/ramstage.c has one or more executable bits set in the file permissions. File src/mainboard/erying/tgl/romstage_fsp_params.c has one or more executable bits set in the file permissions.
In my opinion, the port should be submitted in the current state, and the bugs be fixed in follow-up commits.