Change in ...coreboot[master]: vendorcode/intel/fsp/fsp2_0/cml: Add FSP header files for Cometlake
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31529 )
Change subject: vendorcode/intel/fsp/fsp2_0/cml: Add FSP header files for Cometlake ......................................................................
Patch Set 3: Code-Review-1
(2 comments)
I somehow doubt that this was really reviewed.
https://review.coreboot.org/#/c/31529/3/src/vendorcode/intel/fsp/fsp2_0/come... File src/vendorcode/intel/fsp/fsp2_0/cometlake/FspUpd.h:
https://review.coreboot.org/#/c/31529/3/src/vendorcode/intel/fsp/fsp2_0/come... PS3, Line 3: Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> The date is wrong. It should reflect the date when the contents were written. Obviously not in 2019 as we had this file already last year. If the date is wrong the whole copyright line is void, AFAIK. (not that I'd assume that copyright applies to this file anyway)
https://review.coreboot.org/#/c/31529/3/src/vendorcode/intel/fsp/fsp2_0/come... PS3, Line 40: #define FSPT_UPD_SIGNATURE 0x545F4450554C4643 /* 'CFLUPD_T' */ Same signatures as for Coffee Lake? I was told by somebody @intel that the UPD structs should stay backwards compatible... these are really not.
-
Nico Huber (Code Review)