Attention is currently required from: Angel Pons, Arthur Heymans, Christian Walter, David Hendricks, Jincheng Li, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, TangYiwei, Tim Chu.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81317?usp=email )
Change subject: soc/intel/xeon_sp/gnr: Use OCP_VPD drivers
......................................................................
Patch Set 44:
(2 comments)
Patchset:
PS44:
Common code should not select mainboard specific drivers.
Agree, I will abandon this patch and move the settings into board codes at the moment.
File src/soc/intel/xeon_sp/gnr/Kconfig:
https://review.coreboot.org/c/coreboot/+/81317/comment/66b23368_b4b87f5a :
PS44, Line 19: select OCP_VPD
I don't think selecting (requiring) `OCP_VPD` is a good idea. […]
Yes, good point. I will make a patch later so that we could discuss.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81317?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifeca8cf4312ab66ca03188fe25af88a952073130
Gerrit-Change-Number: 81317
Gerrit-PatchSet: 44
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: TangYiwei
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Thu, 25 Apr 2024 12:43:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment