Attention is currently required from: Furquan Shaikh, Nick Vaccaro, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57345 )
Change subject: driver/intel/pmc_mux/conn: Add type-c info to coreboot table ......................................................................
Patch Set 7:
(4 comments)
File src/drivers/intel/pmc_mux/conn/conn.c:
https://review.coreboot.org/c/coreboot/+/57345/comment/9fdf30e9_b137f498 PS7, Line 17: nit: extra blank line
https://review.coreboot.org/c/coreboot/+/57345/comment/9e8ab907_3999e316 PS7, Line 87: int nit: `uint32_t`
https://review.coreboot.org/c/coreboot/+/57345/comment/de60f667_3aa58e5e PS7, Line 99: { Somewhere you'll need to allocate an entry in CBMEM for this:
cbmem_id.h: `#define CBMEM_ID_TYPE_C_PORTS 0x54595043 /* TYPC */` (and the associated string)
and then allocate cbmem here (pseudocode): ``` static void conn_write_cbmem_entry(struct device *dev) { static uint32_t ports_written; struct type_c_port_info *ports;
if (!connector_count) return;
if (ports_written == 0) { size_t entry_size;
entry_size = sizeof(type_c_port_info) * connector_count; ports = cbmem_add(CBMEM_ID_TYPE_C_PORTS); if (!ports) print_error_and_return; } else { ports = cbmem_find(CBMEM_ID_TYPE_C_PORTS); if (!ports) print_error_and_return; }
const struct drivers_intel_pmc_mux_conn_config *config = config_of(dev); memcpy(&ports[ports_written], config, sizeof(*config)); ports_written++; }; ```
https://review.coreboot.org/c/coreboot/+/57345/comment/8abada97_732613ed PS7, Line 104: ``` static void connector_init(void) { ++connector_count; } ```