build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52655 )
Change subject: asus/am1i-a: create the correct MP tables ......................................................................
Patch Set 2:
(15 comments)
File src/mainboard/asus/am1i-a/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131802): https://review.coreboot.org/c/coreboot/+/52655/comment/eecaf884_e1406877 PS2, Line 25: {GFX_DEVFN, {PIRQ_A, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* APU Integrated Graphics: 0:01.00 - IRQ 3 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131802): https://review.coreboot.org/c/coreboot/+/52655/comment/e02b9ebe_42c88985 PS2, Line 26: {ACTL_DEVFN, {PIRQ_NC, PIRQ_B, PIRQ_NC, PIRQ_NC} }, /* APU HDMI Audio Controller: 0:01.01 - IRQ 4 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131802): https://review.coreboot.org/c/coreboot/+/52655/comment/d1d2b469_daa7fd60 PS2, Line 27: {NB_PCIE_PORT1_DEVFN, {PIRQ_A, PIRQ_B, PIRQ_C, PIRQ_D} }, /* PCIe GPP to dGPU 1:00.00: 0:02.01 - IRQ 3 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131802): https://review.coreboot.org/c/coreboot/+/52655/comment/57c8f13e_b00d2986 PS2, Line 28: {NB_PCIE_PORT5_DEVFN, {PIRQ_B, PIRQ_C, PIRQ_D, PIRQ_A} }, /* PCIe GPP to Eth 2:00.00: 0:02.05 - IRQ 4 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131802): https://review.coreboot.org/c/coreboot/+/52655/comment/21f133de_196c7e8a PS2, Line 29: {XHCI_DEVFN, {PIRQ_C, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* USB XHCI: 0:10.00 - IRQ 5 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131802): https://review.coreboot.org/c/coreboot/+/52655/comment/a1b0e54c_0b12ae95 PS2, Line 30: {SATA_DEVFN, {PIRQ_SATA, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* SATA: 0:11.00 - IRQ 7 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131802): https://review.coreboot.org/c/coreboot/+/52655/comment/5e81e68c_ffa546ae PS2, Line 31: {OHCI1_DEVFN, {PIRQ_OHCI1, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* USB OHCI1: 0:12.00 - IRQ 5 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131802): https://review.coreboot.org/c/coreboot/+/52655/comment/2b09baa2_f7e6a2b4 PS2, Line 32: {EHCI1_DEVFN, {PIRQ_NC, PIRQ_EHCI1, PIRQ_NC, PIRQ_NC} }, /* USB EHCI1: 0:12.02 - IRQ 4 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131802): https://review.coreboot.org/c/coreboot/+/52655/comment/131001a3_138cf19c PS2, Line 33: {OHCI2_DEVFN, {PIRQ_OHCI2, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* USB OHCI2: 0:13.00 - IRQ 5 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131802): https://review.coreboot.org/c/coreboot/+/52655/comment/12934f76_e048955d PS2, Line 34: {EHCI2_DEVFN, {PIRQ_NC, PIRQ_EHCI2, PIRQ_NC, PIRQ_NC} }, /* USB EHCI2: 0:13.02 - IRQ 4 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131802): https://review.coreboot.org/c/coreboot/+/52655/comment/a2ecccf1_38e1d9aa PS2, Line 35: {OHCI3_DEVFN, {PIRQ_OHCI3, PIRQ_NC, PIRQ_NC, PIRQ_NC} }, /* USB OHCI3: 0:16.00 - IRQ 5 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131802): https://review.coreboot.org/c/coreboot/+/52655/comment/f341933b_578cff83 PS2, Line 36: {EHCI3_DEVFN, {PIRQ_NC, PIRQ_EHCI3, PIRQ_NC, PIRQ_NC} }, /* USB EHCI3: 0:16.02 - IRQ 4 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131802): https://review.coreboot.org/c/coreboot/+/52655/comment/fb930381_806416c8 PS2, Line 37: {HDA_DEVFN, {PIRQ_HDA, PIRQ_NC, PIRQ_NC, PIRQ_NC} } /* Southbridge HD Audio: 0:14.02 - IRQ 3 */ line over 96 characters
File src/mainboard/asus/am1i-a/mptable.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131802): https://review.coreboot.org/c/coreboot/+/52655/comment/3bdb2bfb_63a75d78 PS2, Line 127: smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, (bus), (((dev)<<2)|(fn)), ioapic_id, (pin)) line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131802): https://review.coreboot.org/c/coreboot/+/52655/comment/9aef27c4_29227f8f PS2, Line 173: smp_write_lintsrc(mc, (type), MP_IRQ_TRIGGER_EDGE | MP_IRQ_POLARITY_HIGH, bus_isa, (intr), (apicid), (pin)) line over 96 characters
-
build bot (Jenkins) (Code Review)