Attention is currently required from: Arthur Heymans, Martin Roth, ron minnich, Paul Menzel, Stefan Reinauer, Angel Pons, Patrick Rudolph, Ron Minnich, Felix Held.
Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55068 )
Change subject: [WIP]Allow to build romstage sources inside the bootblock
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
You also need to build the current patch set, as the files where only added in patch set 2 [1].
That's it! I needed it as well. Done that. Building for asus/p2b-ls without payload yields this result:
Separate romstage
Name Offset Type Size Comp
cbfs master header 0x0 cbfs header 32 none
fallback/romstage 0x80 stage 17408 none
cpu_microcode_blob.bin 0x4500 microcode 83968 none
fallback/ramstage 0x18d40 stage 52312 LZMA
build_info 0x25a00 raw 98 none
fallback/dsdt.aml 0x25ac0 raw 5630 none
cmos_layout.bin 0x27100 cmos_layout 704 none
fallback/postcar 0x27400 stage 10400 none
(empty) 0x29d00 null 79204 none
bootblock 0x3d280 bootblock 11088 none
romstage folded into bootblock
Name Offset Type Size Comp
cbfs master header 0x0 cbfs header 32 none
cpu_microcode_blob.bin 0x80 microcode 83968 none
fallback/ramstage 0x148c0 stage 52312 LZMA
build_info 0x21580 raw 98 none
fallback/dsdt.aml 0x21640 raw 5630 none
cmos_layout.bin 0x22c80 cmos_layout 704 none
fallback/postcar 0x22f80 stage 10400 none
(empty) 0x25880 null 88804 none
bootblock 0x3b380 bootblock 19008 none
For a savings of 9600 bytes. Less than the 10-20k claimed, but still significant.
I look forward to further activities on the LTO front. Still I would have to leave out microcode to fit the Adaptec SCSI BIOS lifted from vendor firmware to boot from SCSI drives, or attempt to port aic78u2 to seabios (holy F!).
I still have to build it with seabios with a ps/2 init patch for boot testing - I do have issues with a real Model M on ps/2 port.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55068
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id68390edc1ba228b121cca89b80c64a92553e284
Gerrit-Change-Number: 55068
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@chromium.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Branden Waldner
scruffy99@gmail.com
Gerrit-CC: Keith Hui
buurin@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: ron minnich
rminnich@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Ron Minnich
rminnich@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 04 Jun 2021 03:47:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Keith Hui
buurin@gmail.com
Gerrit-MessageType: comment