Attention is currently required from: Shelley Chen, Ravi kumar, Paul Menzel, mturney mturney, Julius Werner. Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49392 )
Change subject: sc7280: Add SHRM firmware support ......................................................................
Patch Set 76:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49392/comment/254dd46a_6e1d5ead PS76, Line 9: SHRM is a system hardware resource manager. : It is used to manage run time DDRSS activities.
Please do not break lines after each sentence, and use the full textwidth of 75 characters per line.
Ack
File src/soc/qualcomm/sc7280/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/49392/comment/88502f95_e596e451 PS76, Line 110: none
Good point. […]
if i keep CBFS_PRERAM_COMPRESSION flag, device getting crashed at romstage with below error messsage. hence, i have keep it as none.
data (compression=2) New segment dstaddr 0x09062b00 memsize 0x8a0 srcaddr 0x1482308c filesize 0x254 Loading Segment: addr: 0x09062b00 memsz: 0x00000000000008a0 filesz: 0x0000000000000254 using LZ4
! exception _sync_sp_el0 ELR = 0x00000000146833e0 ESR = 0x96000021 FAR = 0x0000000009062b04 SPSR = 0x2000000c
-
Ravi Kumar Bokka (Code Review)