Change in coreboot[master]: mb/system76/lemp9: Fix GPIO comments

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Jeremy Soller (Code Review)

20 Jul 2020 20 Jul '20

11:32 p.m.

Jeremy Soller has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43627 )

Change subject: mb/system76/lemp9: Fix GPIO comments ......................................................................

mb/system76/lemp9: Fix GPIO comments

Only a comment change, some GPIOs were incorrectly named

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I1f45f93c3900fab2eb3c1c4bc7a491541a84661f --- M src/mainboard/system76/lemp9/gpio.h 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/43627/1

diff --git a/src/mainboard/system76/lemp9/gpio.h b/src/mainboard/system76/lemp9/gpio.h index 881bd36..312cd87 100644 --- a/src/mainboard/system76/lemp9/gpio.h +++ b/src/mainboard/system76/lemp9/gpio.h @@ -151,11 +151,11 @@ PAD_CFG_NC(GPP_B6), // WLAN_CLKREQ# PAD_CFG_NF(GPP_B7, NONE, DEEP, NF1), - // LAN_CLKREQ# + // CARD_CLKREQ# PAD_CFG_NF(GPP_B8, NONE, DEEP, NF1), - // TBT_CLKREQ# + // SSD2_CLKREQ# PAD_CFG_NF(GPP_B9, NONE, DEEP, NF1), - // SSD_CLKREQ# + // SSD1_CLKREQ# PAD_CFG_NF(GPP_B10, NONE, DEEP, NF1),

// Power Management

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

Angel Pons (Code Review)

21 Jul 21 Jul

12:02 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43627 )

Change subject: mb/system76/lemp9: Fix GPIO comments ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43627/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43627/5//COMMIT_MSG@9 PS5, Line 9: Only a comment change, some GPIOs were incorrectly named Please add a period at the end of the sentence.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f45f93c3900fab2eb3c1c4bc7a491541a84661f Gerrit-Change-Number: 43627 Gerrit-PatchSet: 6 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Mon, 20 Jul 2020 22:02:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jeremy Soller (Code Review)

12:02 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43627

to look at the new patch set (#7).

Change subject: mb/system76/lemp9: Fix GPIO comments ......................................................................

mb/system76/lemp9: Fix GPIO comments

Only a comment change, some GPIOs were incorrectly named

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I1f45f93c3900fab2eb3c1c4bc7a491541a84661f --- M src/mainboard/system76/lemp9/gpio.h 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/43627/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/43627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f45f93c3900fab2eb3c1c4bc7a491541a84661f Gerrit-Change-Number: 43627 Gerrit-PatchSet: 7 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: newpatchset

Jeremy Soller (Code Review)

12:11 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43627

to look at the new patch set (#8).

Change subject: mb/system76/lemp9: Fix GPIO comments ......................................................................

mb/system76/lemp9: Fix GPIO comments

Only a comment change, some GPIOs were incorrectly named.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I1f45f93c3900fab2eb3c1c4bc7a491541a84661f --- M src/mainboard/system76/lemp9/gpio.h 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/43627/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/43627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f45f93c3900fab2eb3c1c4bc7a491541a84661f Gerrit-Change-Number: 43627 Gerrit-PatchSet: 8 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: newpatchset

Michael Niewöhner (Code Review)

10:06 a.m.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43627 )

Change subject: mb/system76/lemp9: Fix GPIO comments ......................................................................

Patch Set 11: Code-Review-1

this and more is covered in CB:43650 and it's parents

-- To view, visit https://review.coreboot.org/c/coreboot/+/43627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f45f93c3900fab2eb3c1c4bc7a491541a84661f Gerrit-Change-Number: 43627 Gerrit-PatchSet: 11 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 21 Jul 2020 08:06:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Jeremy Soller (Code Review)

4:20 p.m.

Hello build bot (Jenkins), Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43627

to look at the new patch set (#12).

Change subject: mb/system76/lemp9: Fix GPIO comments ......................................................................

mb/system76/lemp9: Fix GPIO comments

Only a comment change, some GPIOs were incorrectly named.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I1f45f93c3900fab2eb3c1c4bc7a491541a84661f --- M src/mainboard/system76/lemp9/gpio.h 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/43627/12

-- To view, visit https://review.coreboot.org/c/coreboot/+/43627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f45f93c3900fab2eb3c1c4bc7a491541a84661f Gerrit-Change-Number: 43627 Gerrit-PatchSet: 12 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Jeremy Soller (Code Review)

5:24 p.m.

New subject: Change in coreboot[master]: mb/system76/lemp9: fix GPIO comments

Hello build bot (Jenkins), Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43627

to look at the new patch set (#14).

Change subject: mb/system76/lemp9: fix GPIO comments ......................................................................

mb/system76/lemp9: fix GPIO comments

Only a comment change, some GPIOs were incorrectly named.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I1f45f93c3900fab2eb3c1c4bc7a491541a84661f --- M src/mainboard/system76/lemp9/gpio.h 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/43627/14

-- To view, visit https://review.coreboot.org/c/coreboot/+/43627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f45f93c3900fab2eb3c1c4bc7a491541a84661f Gerrit-Change-Number: 43627 Gerrit-PatchSet: 14 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Michael Niewöhner (Code Review)

5:30 p.m.

New subject: Change in coreboot[master]: mb/system76/lemp9: fix GPIO comments

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43627 )

Change subject: mb/system76/lemp9: fix GPIO comments ......................................................................

Patch Set 15: Code-Review-1

...

Patch Set 11: Code-Review-1

this and more is covered in CB:43650 and it's parents

-- To view, visit https://review.coreboot.org/c/coreboot/+/43627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f45f93c3900fab2eb3c1c4bc7a491541a84661f Gerrit-Change-Number: 43627 Gerrit-PatchSet: 15 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 21 Jul 2020 15:30:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Jeremy Soller (Code Review)

22 Jul 22 Jul

2:45 p.m.

New subject: Change in coreboot[master]: mb/system76/lemp9: fix GPIO comments

Hello build bot (Jenkins), Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43627

to look at the new patch set (#16).

Change subject: mb/system76/lemp9: fix GPIO comments ......................................................................

mb/system76/lemp9: fix GPIO comments

Only a comment change, some GPIOs were incorrectly named.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I1f45f93c3900fab2eb3c1c4bc7a491541a84661f --- M src/mainboard/system76/lemp9/gpio.h 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/43627/16

-- To view, visit https://review.coreboot.org/c/coreboot/+/43627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f45f93c3900fab2eb3c1c4bc7a491541a84661f Gerrit-Change-Number: 43627 Gerrit-PatchSet: 16 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Jeremy Soller (Code Review)

4:09 p.m.

New subject: Change in coreboot[master]: mb/system76/lemp9: fix GPIO comments

Hello build bot (Jenkins), Michael Niewöhner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43627

to look at the new patch set (#18).

Change subject: mb/system76/lemp9: fix GPIO comments ......................................................................

mb/system76/lemp9: fix GPIO comments

Only a comment change, some GPIOs were incorrectly named.

Signed-off-by: Jeremy Soller jeremy@system76.com Change-Id: I1f45f93c3900fab2eb3c1c4bc7a491541a84661f --- M src/mainboard/system76/lemp9/gpio.h 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/43627/18

-- To view, visit https://review.coreboot.org/c/coreboot/+/43627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f45f93c3900fab2eb3c1c4bc7a491541a84661f Gerrit-Change-Number: 43627 Gerrit-PatchSet: 18 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Michael Niewöhner (Code Review)

31 Aug 31 Aug

1:06 a.m.

New subject: Change in coreboot[master]: mb/system76/lemp9: fix GPIO comments

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43627 )

Change subject: mb/system76/lemp9: fix GPIO comments ......................................................................

Patch Set 19: Code-Review-2

CB:43650 was merged; drop this

-- To view, visit https://review.coreboot.org/c/coreboot/+/43627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f45f93c3900fab2eb3c1c4bc7a491541a84661f Gerrit-Change-Number: 43627 Gerrit-PatchSet: 19 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 30 Aug 2020 23:06:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Jeremy Soller (Code Review)

3 Sep 3 Sep

10:57 p.m.

New subject: Change in coreboot[master]: mb/system76/lemp9: fix GPIO comments

Jeremy Soller has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43627 )

Change subject: mb/system76/lemp9: fix GPIO comments ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/43627 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f45f93c3900fab2eb3c1c4bc7a491541a84661f Gerrit-Change-Number: 43627 Gerrit-PatchSet: 19 Gerrit-Owner: Jeremy Soller jeremy@system76.com Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1542

days inactive

1587

days old

coreboot-gerrit@coreboot.org

11 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
Jeremy Soller (Code Review)
Michael Niewöhner (Code Review)