Attention is currently required from: Justin van Son, Patrick Rudolph, Christian Walter, Angel Pons.
David Milosevic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67759 )
Change subject: mb/prodrive/hermes: Add part numbers to SMBIOS
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/prodrive/hermes/mainboard.c:
https://review.coreboot.org/c/coreboot/+/67759/comment/6da5cd49_a99df894
PS2, Line 180: memset(buffer, 0, sizeof(buffer));
No, it's not redundant because the buffer is declared as `static`, so the initialization in line 176 […]
never mind...did not see the second call to format_pn :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67759
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26c17ab37859c3306fe72c3f0cdc1d3787b48157
Gerrit-Change-Number: 67759
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Milosevic
David.Milosevic@9elements.com
Gerrit-CC: Justin van Son
justin.van.son@prodrive-technologies.com
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Justin van Son
justin.van.son@prodrive-technologies.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 07 Oct 2022 15:05:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: David Milosevic
David.Milosevic@9elements.com
Gerrit-MessageType: comment