Hello Martin Roth, Eric Peers,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/39867
to review the following change.
Change subject: soc/amd/picasso: Add Kconfig option for chip footprint ......................................................................
soc/amd/picasso: Add Kconfig option for chip footprint
Pollock uses the FT5 footprint, so add the Kconfig option to allow us to differentiate the chips.
Change-Id: Ia4663d38f1824786f14b6aa000adf27d64e70b5f Signed-off-by: Martin Roth martinroth@chromium.org Reviewed-on: https://chromium-review.googlesource.com/2051509 Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Eric Peers epeers@google.com --- M src/soc/amd/picasso/Kconfig 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/39867/1
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index a7423e9..7d4df01 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -59,6 +59,16 @@ bool default n
+config AMD_FP5 + def_bool y if !AMD_FT5 + help + The FP5 supports higher-wattage parts and dual DDR-4 memory + +config AMD_FT5 + def_bool n + help + The FT5 supports low-power parts and single-channel DDR-4 + config PRERAM_CBMEM_CONSOLE_SIZE hex default 0x1600
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39867 )
Change subject: soc/amd/picasso: Add Kconfig option for chip footprint ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39867 )
Change subject: soc/amd/picasso: Add Kconfig option for chip footprint ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39867/1/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/39867/1/src/soc/amd/picasso/Kconfig... PS1, Line 65: The FP5 supports higher-wattage parts and dual DDR-4 memory Please add a dot/period at the end of sentences.
https://review.coreboot.org/c/coreboot/+/39867/1/src/soc/amd/picasso/Kconfig... PS1, Line 70: The FT5 supports low-power parts and single-channel DDR-4 Please add a dot/period at the end of sentences.
Hello build bot (Jenkins), Raul Rangel, Martin Roth, Eric Peers,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39867
to look at the new patch set (#2).
Change subject: soc/amd/picasso: Add Kconfig option for chip footprint ......................................................................
soc/amd/picasso: Add Kconfig option for chip footprint
Pollock uses the FT5 footprint, so add the Kconfig option to allow us to differentiate the chips.
Change-Id: Ia4663d38f1824786f14b6aa000adf27d64e70b5f Signed-off-by: Martin Roth martinroth@chromium.org Reviewed-on: https://chromium-review.googlesource.com/2051509 Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Eric Peers epeers@google.com Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/picasso/Kconfig 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/39867/2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39867 )
Change subject: soc/amd/picasso: Add Kconfig option for chip footprint ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39867/1/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/39867/1/src/soc/amd/picasso/Kconfig... PS1, Line 65: The FP5 supports higher-wattage parts and dual DDR-4 memory
Please add a dot/period at the end of sentences.
Done
https://review.coreboot.org/c/coreboot/+/39867/1/src/soc/amd/picasso/Kconfig... PS1, Line 70: The FT5 supports low-power parts and single-channel DDR-4
Please add a dot/period at the end of sentences.
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39867 )
Change subject: soc/amd/picasso: Add Kconfig option for chip footprint ......................................................................
Patch Set 2: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39867 )
Change subject: soc/amd/picasso: Add Kconfig option for chip footprint ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/39867/2/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/39867/2/src/soc/amd/picasso/Kconfig... PS2, Line 65: DDR-4 DDR4
https://review.coreboot.org/c/coreboot/+/39867/2/src/soc/amd/picasso/Kconfig... PS2, Line 70: DDR-4 DDR4
Hello build bot (Jenkins), Raul Rangel, Martin Roth, Paul Menzel, Angel Pons, Eric Peers,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39867
to look at the new patch set (#3).
Change subject: soc/amd/picasso: Add Kconfig option for chip footprint ......................................................................
soc/amd/picasso: Add Kconfig option for chip footprint
Pollock uses the FT5 footprint, so add the Kconfig option to allow us to differentiate the chips.
Change-Id: Ia4663d38f1824786f14b6aa000adf27d64e70b5f Signed-off-by: Martin Roth martinroth@chromium.org Reviewed-on: https://chromium-review.googlesource.com/2051509 Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Eric Peers epeers@google.com Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/picasso/Kconfig 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/39867/3
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39867 )
Change subject: soc/amd/picasso: Add Kconfig option for chip footprint ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39867/2/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/39867/2/src/soc/amd/picasso/Kconfig... PS2, Line 65: DDR-4
DDR4
Done
https://review.coreboot.org/c/coreboot/+/39867/2/src/soc/amd/picasso/Kconfig... PS2, Line 70: DDR-4
DDR4
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39867 )
Change subject: soc/amd/picasso: Add Kconfig option for chip footprint ......................................................................
Patch Set 3: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39867 )
Change subject: soc/amd/picasso: Add Kconfig option for chip footprint ......................................................................
soc/amd/picasso: Add Kconfig option for chip footprint
Pollock uses the FT5 footprint, so add the Kconfig option to allow us to differentiate the chips.
Change-Id: Ia4663d38f1824786f14b6aa000adf27d64e70b5f Signed-off-by: Martin Roth martinroth@chromium.org Reviewed-on: https://chromium-review.googlesource.com/2051509 Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Eric Peers epeers@google.com Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/39867 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/soc/amd/picasso/Kconfig 1 file changed, 10 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig index a7423e9..d9211b4 100644 --- a/src/soc/amd/picasso/Kconfig +++ b/src/soc/amd/picasso/Kconfig @@ -59,6 +59,16 @@ bool default n
+config AMD_FP5 + def_bool y if !AMD_FT5 + help + The FP5 package supports higher-wattage parts and dual channel DDR4 memory. + +config AMD_FT5 + def_bool n + help + The FT5 package supports low-power parts and single-channel DDR4 memory. + config PRERAM_CBMEM_CONSOLE_SIZE hex default 0x1600
-
Angel Pons (Code Review) -
Felix Held (Code Review)
-
Paul Menzel (Code Review)
-
Raul Rangel (Code Review)