Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/22604 )
Change subject: cpu/intel/speedstep: Add Netburst ......................................................................
Patch Set 77:
(2 comments)
https://review.coreboot.org/c/coreboot/+/22604/77/src/cpu/intel/speedstep/sp... File src/cpu/intel/speedstep/speedstep.c:
https://review.coreboot.org/c/coreboot/+/22604/77/src/cpu/intel/speedstep/sp... PS77, Line 52: SPEEDSTEP_STATE_FROM_MSR(msr.lo, state_mask); This now fits in 96 characters.
https://review.coreboot.org/c/coreboot/+/22604/77/src/cpu/intel/speedstep/sp... PS77, Line 93: if (c.x86 == 6 && c.x86_model == 0xe) { Why is the if-else statement better than the switch?