Attention is currently required from: Martin Roth, Julius Werner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50247 )
Change subject: Documentation: Codify some guidelines for headers and chain-including
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File Documentation/coding_style.md:
https://review.coreboot.org/c/coreboot/+/50247/comment/fc6b64ce_c2357b72
PS1, Line 876: take advantage of the macro
take advantage of the `ARRAY_SIZE` macro:
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50247
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibbcde306a814f52b3a41b58c7a33bdd99b0187e0
Gerrit-Change-Number: 50247
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 03 Feb 2021 10:28:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment