Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Nick Vaccaro, Patrick Rudolph. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58352 )
Change subject: soc/intel/alderlake: enable gpio locking ......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/alderlake/gpio.c:
https://review.coreboot.org/c/coreboot/+/58352/comment/9d7bfc73_d8bc2d68 PS1, Line 251: #if CONFIG(SOC_INTEL_COMMON_BLOCK_SMM_LOCK_GPIO_PADS)
Are you suggesting we shouldn't need the guard at all for the locking feature, or just that we don't […]
Yes, once you add a weak soc_gpio_lock_config override, you dont need this guard. Even if ADL disables CONFIG(SOC_INTEL_COMMON_BLOCK_SMM_LOCK_GPIO_PADS), things will compile and work as expected.
``` if (CONFIG(SOC_INTEL_COMMON_BLOCK_SMM_LOCK_GPIO_PADS)) soc_lock_gpio(); ```
The above snippet of code in smihandler.c in the previous CL will ensure that the GPIOs are locked at run-time if the config is enabled and stay unlocked if it is disabled.
The code to lock GPIO config and the associated mainboard/soc GPIO tables are always compiled into coreboot.