Attention is currently required from: Gaggery Tsai, Kedar J. Karanje, Tarun Tuli, Jérémy Compostella, Tim Wawrzynczak, Sridhar Siricilla, Kane Chen.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68900 )
Change subject: mb/google/brya : Set EPP value for Vell board
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68900/comment/1ae81006_5b295220
PS3, Line 11: TEST=Verified code build for Vell board
Please refer b:215526166 for details.
You should specify what is being test with this CL and benefits beyond just mentioning the bug number.
In short, you can just mention the PLT test results w/ and w/o the CL, so, the impact of this CL is justified.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68900
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41b15b84025d25cf59dac2d85826a3de9d725bae
Gerrit-Change-Number: 68900
Gerrit-PatchSet: 4
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Kedar J. Karanje
kedar.j.karanje@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Attention: Kedar J. Karanje
kedar.j.karanje@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Comment-Date: Tue, 01 Nov 2022 12:06:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment