Change in ...coreboot[master]: sifive/hifive-unleashed: Drop unneeded console_tx_flush()

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31369

Change subject: sifive/hifive-unleashed: Drop unneeded console_tx_flush()
......................................................................

sifive/hifive-unleashed: Drop unneeded console_tx_flush()

Every printk() call already does console_tx_flush()
so there should not be anything in transmit buffer
when we return from console_init().

Change-Id: Iff2927c02d2c8031907620a056782bb014f20162
Signed-off-by: Kyösti Mälkki 
---
M src/mainboard/sifive/hifive-unleashed/romstage.c
1 file changed, 0 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/31369/1

diff --git a/src/mainboard/sifive/hifive-unleashed/romstage.c b/src/mainboard/sifive/hifive-unleashed/romstage.c
index 8277141..0611a6d 100644
--- a/src/mainboard/sifive/hifive-unleashed/romstage.c
+++ b/src/mainboard/sifive/hifive-unleashed/romstage.c
@@ -27,12 +27,6 @@

/* TODO: Follow Section 6.3 (FSBL) of the FU540 manual */

-	/*
-	 * Flush console before changing clock/UART divisor to prevent garbage
-	 * being printed.
-	 */
-	console_tx_flush();
-
    clock_init();

// re-initialize UART

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31369 )

Change subject: sifive/hifive-unleashed: Drop unneeded console_tx_flush()
......................................................................

Patch Set 1: Code-Review+1

[Xiang Wang (Code Review)]

Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31369 )

Change subject: sifive/hifive-unleashed: Drop unneeded console_tx_flush()
......................................................................

Patch Set 3: Code-Review+1

[Philipp Hug (Code Review)]

Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31369 )

Change subject: sifive/hifive-unleashed: Drop unneeded console_tx_flush()
......................................................................

Patch Set 3: Code-Review+2

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31369 )

Change subject: sifive/hifive-unleashed: Drop unneeded console_tx_flush()
......................................................................

sifive/hifive-unleashed: Drop unneeded console_tx_flush()

Every printk() call already does console_tx_flush()
so there should not be anything in transmit buffer
when we return from console_init().

Change-Id: Iff2927c02d2c8031907620a056782bb014f20162
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/31369
Reviewed-by: Xiang Wang 
Reviewed-by: Philipp Hug 
Reviewed-by: Paul Menzel 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/sifive/hifive-unleashed/romstage.c
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Xiang Wang: Looks good to me, but someone else must approve
  Philipp Hug: Looks good to me, approved

diff --git a/src/mainboard/sifive/hifive-unleashed/romstage.c b/src/mainboard/sifive/hifive-unleashed/romstage.c
index 8277141..0611a6d 100644
--- a/src/mainboard/sifive/hifive-unleashed/romstage.c
+++ b/src/mainboard/sifive/hifive-unleashed/romstage.c
@@ -27,12 +27,6 @@

/* TODO: Follow Section 6.3 (FSBL) of the FU540 manual */

-	/*
-	 * Flush console before changing clock/UART divisor to prevent garbage
-	 * being printed.
-	 */
-	console_tx_flush();
-
    clock_init();

// re-initialize UART