Attention is currently required from: Paul Menzel, Julius Werner. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52136 )
Change subject: tests/lib/malloc-test: Fix possible memory overrun ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Sorry, where is the overrun here? These two symbols point to the same address, right? […]
Yes, _heap points to the beginning of _test_heap. Pointers should be equal.
This Coverity report looked suspicious to me. It's not strange that Coverity does not know how to parse TEST_SYMBOL() macros and get correct buffer from symbol. Should I create changes like that in future but with comment like: "To silence Coverity", or just ignore irrelevant "bugs" reported by it? (Should I abandon this change as well?)
-
Jakub Czapiga (Code Review)