HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43954 )
Change subject: src/superio: Add missing <{stdbool,stdint}.h> ......................................................................
src/superio: Add missing <{stdbool,stdint}.h>
Change-Id: I7fb1a65278efa0fe8656d5d6ea8bf30161818ed6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/aspeed/ast2400/chip.h M src/superio/ite/common/env_ctrl_chip.h M src/superio/nuvoton/nct5104d/superio.c 3 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/43954/1
diff --git a/src/superio/aspeed/ast2400/chip.h b/src/superio/aspeed/ast2400/chip.h index 262f815..1634a34 100644 --- a/src/superio/aspeed/ast2400/chip.h +++ b/src/superio/aspeed/ast2400/chip.h @@ -3,6 +3,8 @@ #ifndef __SUPERIO_ASPEED__AST2400_CHIP_H__ #define __SUPERIO_ASPEED__AST2400_CHIP_H__
+#include <stdbool.h> + struct superio_aspeed_ast2400_config { /* On AST2500 only 1: ESPI, 0: LPC */ bool use_espi; diff --git a/src/superio/ite/common/env_ctrl_chip.h b/src/superio/ite/common/env_ctrl_chip.h index 6a027b9..e2aaec3 100644 --- a/src/superio/ite/common/env_ctrl_chip.h +++ b/src/superio/ite/common/env_ctrl_chip.h @@ -3,6 +3,9 @@ #ifndef SUPERIO_ITE_ENV_CTRL_CHIP_H #define SUPERIO_ITE_ENV_CTRL_CHIP_H
+#include <stdbool.h> +#include <stdint.h> + #define ITE_EC_TMPIN_CNT 3
#if CONFIG(SUPERIO_ITE_ENV_CTRL_5FANS) diff --git a/src/superio/nuvoton/nct5104d/superio.c b/src/superio/nuvoton/nct5104d/superio.c index 3351ad9..db3d74d 100644 --- a/src/superio/nuvoton/nct5104d/superio.c +++ b/src/superio/nuvoton/nct5104d/superio.c @@ -3,6 +3,8 @@ #include <console/console.h> #include <device/pnp.h> #include <device/device.h> +#include <stdbool.h> +#include <stdint.h> #include <superio/conf_mode.h>
#include "nct5104d.h"
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43954 )
Change subject: src/superio: Add missing <{stdbool,stdint}.h> ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/43954/1/src/superio/ite/common/env_... File src/superio/ite/common/env_ctrl_chip.h:
https://review.coreboot.org/c/coreboot/+/43954/1/src/superio/ite/common/env_... PS1, Line 7: #include <stdint.h> add types.h instead of those two?
https://review.coreboot.org/c/coreboot/+/43954/1/src/superio/nuvoton/nct5104... File src/superio/nuvoton/nct5104d/superio.c:
https://review.coreboot.org/c/coreboot/+/43954/1/src/superio/nuvoton/nct5104... PS1, Line 7: #include <stdint.h> same
Hello build bot (Jenkins), Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43954
to look at the new patch set (#2).
Change subject: src/superio: Add missing <{stdbool,stdint}.h> ......................................................................
src/superio: Add missing <{stdbool,stdint}.h>
Change-Id: I7fb1a65278efa0fe8656d5d6ea8bf30161818ed6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/aspeed/ast2400/chip.h M src/superio/ite/common/env_ctrl_chip.h M src/superio/nuvoton/nct5104d/superio.c 3 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/43954/2
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43954 )
Change subject: src/superio: Add missing <{stdbool,stdint}.h> ......................................................................
Abandoned
-
Felix Held (Code Review) -
HAOUAS Elyes (Code Review)