Michael Niewöhner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35448 )
Change subject: soc/intel/skylake: lock down TCO on pch finalize ......................................................................
soc/intel/skylake: lock down TCO on pch finalize
Change-Id: I5bd95b3580adc0f4cffa667f8979b7cf08925720 Signed-off-by: Michael Niewöhner michael.niewoehner@8com.de --- M src/soc/intel/skylake/finalize.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/35448/1
diff --git a/src/soc/intel/skylake/finalize.c b/src/soc/intel/skylake/finalize.c index 8afaf4d..0d6f737 100644 --- a/src/soc/intel/skylake/finalize.c +++ b/src/soc/intel/skylake/finalize.c @@ -26,6 +26,7 @@ #include <intelblocks/lpc_lib.h> #include <intelblocks/p2sb.h> #include <intelblocks/pcr.h> +#include <intelblocks/tco.h> #include <intelblocks/thermal.h> #include <reg_script.h> #include <spi-generic.h> @@ -72,6 +73,8 @@ config_t *config; u8 reg8;
+ tco_lockdown(); + /* Display me status before we hide it */ intel_me_status();
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35448 )
Change subject: soc/intel/skylake: lock down TCO on pch finalize ......................................................................
Patch Set 1:
LGTM, just wondering if its a porting effort from CNL/ICL to SKL or you are fixing some issue ?
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35448 )
Change subject: soc/intel/skylake: lock down TCO on pch finalize ......................................................................
Patch Set 1: Code-Review+1
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35448 )
Change subject: soc/intel/skylake: lock down TCO on pch finalize ......................................................................
Patch Set 1:
Patch Set 1:
LGTM, just wondering if its a porting effort from CNL/ICL to SKL or you are fixing some issue ?
It's a port; currently TCO isn't locked on SKL/KBL
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35448 )
Change subject: soc/intel/skylake: lock down TCO on pch finalize ......................................................................
Patch Set 1: Code-Review+2
Hello Patrick Rudolph, Subrata Banik, Angel Pons, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35448
to look at the new patch set (#3).
Change subject: soc/intel/skylake: lock down TCO on pch finalize ......................................................................
soc/intel/skylake: lock down TCO on pch finalize
Tested on X11SSM-F
Change-Id: I5bd95b3580adc0f4cffa667f8979b7cf08925720 Signed-off-by: Michael Niewöhner michael.niewoehner@8com.de --- M src/soc/intel/skylake/finalize.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/35448/3
Hello Patrick Rudolph, Subrata Banik, Angel Pons, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35448
to look at the new patch set (#4).
Change subject: soc/intel/skylake: lock down TCO on pch finalize ......................................................................
soc/intel/skylake: lock down TCO on pch finalize
Change-Id: I5bd95b3580adc0f4cffa667f8979b7cf08925720 Signed-off-by: Michael Niewöhner michael.niewoehner@8com.de --- M src/soc/intel/skylake/finalize.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/35448/4
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35448 )
Change subject: soc/intel/skylake: lock down TCO on pch finalize ......................................................................
Patch Set 4:
*ping* ;-) Any comments on this?
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35448 )
Change subject: soc/intel/skylake: lock down TCO on pch finalize ......................................................................
soc/intel/skylake: lock down TCO on pch finalize
Change-Id: I5bd95b3580adc0f4cffa667f8979b7cf08925720 Signed-off-by: Michael Niewöhner michael.niewoehner@8com.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/35448 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/skylake/finalize.c 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved
diff --git a/src/soc/intel/skylake/finalize.c b/src/soc/intel/skylake/finalize.c index 8afaf4d..0d6f737 100644 --- a/src/soc/intel/skylake/finalize.c +++ b/src/soc/intel/skylake/finalize.c @@ -26,6 +26,7 @@ #include <intelblocks/lpc_lib.h> #include <intelblocks/p2sb.h> #include <intelblocks/pcr.h> +#include <intelblocks/tco.h> #include <intelblocks/thermal.h> #include <reg_script.h> #include <spi-generic.h> @@ -72,6 +73,8 @@ config_t *config; u8 reg8;
+ tco_lockdown(); + /* Display me status before we hide it */ intel_me_status();
-
Michael Niewöhner (Code Review) -
Subrata Banik (Code Review)