Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons, Ronak Kanabar, Eric Lai, Werner Zeh.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66706 )
Change subject: soc/intel/alderlake: Remove dependency of FSP-S CpuMpPei Module
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/66706/comment/b1831631_338a2ec2
PS5, Line 14:
nit: change to spaces as the indentation above and below.
https://review.coreboot.org/c/coreboot/+/66706/comment/5bc83ed1_1958ea29
PS5, Line 26: https://github.com/tianocore/edk2/blob/master/UefiCpuPkg/CpuMpPei/CpuMpPei.c...
Please make sure this is captured in archive.org and use the archive.org url in the commit. Especially because you're linking to the master branch this is likely to change in the future.
Alternatively, consider whether the URL is really needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66706
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ebe0bcfda513e79e791df7ab54b357aa23d295c
Gerrit-Change-Number: 66706
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Sun, 04 Sep 2022 17:01:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment