Attention is currently required from: Paul Menzel, Werner Zeh, Patrick Rudolph. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61177 )
Change subject: soc/intel/ehl: Add Kconfig option to disable reset on TCO expiration ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61177/comment/3e133be9_7d1521af PS1, Line 11: In this : applications the TCO expire event generates an interrupt and software : takes care.
Yes, the most meaningful state of the TCO is that it causes a reset on the second expiration, I agre […]
Thanks, I guess what I was missing is that the NO_REBOOT bit is generally not part of the (OS) TCO interface.
IMO, SoC level is correct. Generally such OS preferences should happen in the ramstage, usually around device init. However, as we have no ramstage driver for the TCO (I assume?), that might be overkill.
File src/soc/intel/elkhartlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/61177/comment/daa7cf61_663419f6 PS2, Line 222: expires *for the second time*
https://review.coreboot.org/c/coreboot/+/61177/comment/f9de136b_48a9f5ed PS2, Line 223: This might be useful depending on the TCO policy. This seems very vague. Maybe mention instead that the OS is generally unaware of the NO_REBOOT bit. So one might have to configure the OS preference here.