Change in coreboot[master]: mb/google/octopus/variants/dood: Add G2Touch touchscreen support
Kenneth Chan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46675 )
Change subject: mb/google/octopus/variants/dood: Add G2Touch touchscreen support ......................................................................
mb/google/octopus/variants/dood: Add G2Touch touchscreen support
Add G2Touch touchscreen support for dood.
BUG=b:171526389 BRANCH=octopus TEST=emerge-octopus coreboot chromeos-bootimage, and check touchscreen work.
Signed-off-by: Kenneth Chan kenneth.chan@quanta.corp-partner.google.com Change-Id: Ica7d893de285c2dd1efcd43ac74919bdd5d5ac17 --- M src/mainboard/google/octopus/variants/dood/overridetree.cb 1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/46675/1
diff --git a/src/mainboard/google/octopus/variants/dood/overridetree.cb b/src/mainboard/google/octopus/variants/dood/overridetree.cb index e1f12cf..6e767dd 100644 --- a/src/mainboard/google/octopus/variants/dood/overridetree.cb +++ b/src/mainboard/google/octopus/variants/dood/overridetree.cb @@ -144,6 +144,20 @@ register "has_power_resource" = "1" device i2c 39 on end end + chip drivers/i2c/hid + register "generic.hid" = ""GTCH7502"" + register "generic.desc" = ""G2TOUCH Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" + register "generic.reset_delay_ms" = "50" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_146)" + register "generic.enable_delay_ms" = "1" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 40 on end + end end # - I2C 7 end
Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46675 )
Change subject: mb/google/octopus/variants/dood: Add G2Touch touchscreen support ......................................................................
Patch Set 1: Code-Review+1
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46675 )
Change subject: mb/google/octopus/variants/dood: Add G2Touch touchscreen support ......................................................................
Patch Set 1:
clarify difference between GTCH7502 and TGCH7503 in the issue.
Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46675 )
Change subject: mb/google/octopus/variants/dood: Add G2Touch touchscreen support ......................................................................
Patch Set 1:
Patch Set 1:
clarify difference between GTCH7502 and TGCH7503 in the issue.
GTCH7502 is for Panel 11.6” T14. GTCH7503 is for other Panel.
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46675 )
Change subject: mb/google/octopus/variants/dood: Add G2Touch touchscreen support ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46675 )
Change subject: mb/google/octopus/variants/dood: Add G2Touch touchscreen support ......................................................................
mb/google/octopus/variants/dood: Add G2Touch touchscreen support
Add G2Touch touchscreen support for dood.
BUG=b:171526389 BRANCH=octopus TEST=emerge-octopus coreboot chromeos-bootimage, and check touchscreen work.
Signed-off-by: Kenneth Chan kenneth.chan@quanta.corp-partner.google.com Change-Id: Ica7d893de285c2dd1efcd43ac74919bdd5d5ac17 Reviewed-on: https://review.coreboot.org/c/coreboot/+/46675 Reviewed-by: Marco Chen marcochen@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/octopus/variants/dood/overridetree.cb 1 file changed, 14 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Marco Chen: Looks good to me, approved Kenneth Chan: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/octopus/variants/dood/overridetree.cb b/src/mainboard/google/octopus/variants/dood/overridetree.cb index e1f12cf..6e767dd 100644 --- a/src/mainboard/google/octopus/variants/dood/overridetree.cb +++ b/src/mainboard/google/octopus/variants/dood/overridetree.cb @@ -144,6 +144,20 @@ register "has_power_resource" = "1" device i2c 39 on end end + chip drivers/i2c/hid + register "generic.hid" = ""GTCH7502"" + register "generic.desc" = ""G2TOUCH Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPIO_212_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_105)" + register "generic.reset_delay_ms" = "50" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_146)" + register "generic.enable_delay_ms" = "1" + register "generic.has_power_resource" = "1" + register "generic.disable_gpio_export_in_crs" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 40 on end + end end # - I2C 7 end
-
Kenneth Chan (Code Review) -
Marco Chen (Code Review)
-
Patrick Georgi (Code Review)