[L] Change in coreboot[master]: intelp2m/patform/sunrise: Add unit tests - coreboot-gerrit

2 Jan 2023


      Attention is currently required from: Martin L Roth, Maxim Polyakov, David Hendricks.
ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67132 )
Change subject: intelp2m/patform/sunrise: Add unit tests
......................................................................
Patch Set 14:
(1 comment)
File util/intelp2m/Makefile:
https://review.coreboot.org/c/coreboot/+/67132/comment/2c8cbb94_b3711dfe 
PS14, Line 9: 	go build -v -o $(PROJECT_NAME)
I find myself wondering why you have the -o here. In my experience, a go build -v would build ./intelp2m, because we're in that directory?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/67132
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15c7483f120a330849d4bad036427be205b0911c
Gerrit-Change-Number: 67132
Gerrit-PatchSet: 14
Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Attention: David Hendricks david.hendricks@gmail.com
Gerrit-Comment-Date: Mon, 02 Jan 2023 02:22:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment