Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40023 )
Change subject: mb/volteer: enable Early Command Training ......................................................................
Patch Set 9:
(5 comments)
https://review.coreboot.org/c/coreboot/+/40023/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40023/9//COMMIT_MSG@7 PS9, Line 7: Early Command Training By the way, there is no public information on what ECT does. A Web search only shows coreboot’s source files.
https://review.coreboot.org/c/coreboot/+/40023/9//COMMIT_MSG@7 PS9, Line 7: mb/volteer mb/google/volteer:
https://review.coreboot.org/c/coreboot/+/40023/9//COMMIT_MSG@10 PS9, Line 10: Command Training since FSP v2527 supports ECT. It looks like we misunderstand each other. I thought you meant:
Early in board bring-up ECT was disabled as it’s not really needed. As the board boots now, ECT can be enabled.
But you actually seem to suggest, that it wasn’t supported or buggy in early FSP. (The bug report below is also not accessible to me, so more details would be nice.) Please elaborate.
https://review.coreboot.org/c/coreboot/+/40023/9//COMMIT_MSG@14 PS9, Line 14: TEST= Build and Boot volteer What is different now with ECT?
https://review.coreboot.org/c/coreboot/+/40023/9//COMMIT_MSG@14 PS9, Line 14: Boot boot
-
Paul Menzel (Code Review)