build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/15164 )
Change subject: nb/amd/pi/00730F01: Add initial native IVRS support ......................................................................
Patch Set 20:
(7 comments)
https://review.coreboot.org/#/c/15164/20/src/northbridge/amd/pi/00730F01/nor... File src/northbridge/amd/pi/00730F01/northbridge.c:
https://review.coreboot.org/#/c/15164/20/src/northbridge/amd/pi/00730F01/nor... PS20, Line 507: is_pcie = pci_find_capability(dev, PCI_CAP_ID_PCIE); line over 80 characters
https://review.coreboot.org/#/c/15164/20/src/northbridge/amd/pi/00730F01/nor... PS20, Line 528: } else if ((header_type == PCI_HEADER_TYPE_NORMAL) && line over 80 characters
https://review.coreboot.org/#/c/15164/20/src/northbridge/amd/pi/00730F01/nor... PS20, Line 608: printk(BIOS_WARNING, "%s: G-series northbridge device not present!\n", __func__); line over 80 characters
https://review.coreboot.org/#/c/15164/20/src/northbridge/amd/pi/00730F01/nor... PS20, Line 609: printk(BIOS_WARNING, "%s: IVRS table not generated...\n", __func__); line over 80 characters
https://review.coreboot.org/#/c/15164/20/src/northbridge/amd/pi/00730F01/nor... PS20, Line 624: ivrs->ivhd.flags |= 0x10; /* Enable ATS support */ line over 80 characters
https://review.coreboot.org/#/c/15164/20/src/northbridge/amd/pi/00730F01/nor... PS20, Line 626: ivrs->ivhd.device_id = 0x2 | (nb_dev->bus->secondary << 8); /* BDF <bus>:00.2 */ line over 80 characters
https://review.coreboot.org/#/c/15164/20/src/northbridge/amd/pi/00730F01/nor... PS20, Line 627: ivrs->ivhd.capability_offset = 0x40; /* Capability block 0x40 (type 0xf, "Secure device") */ line over 80 characters
-
build bot (Jenkins) (Code Review)