Attention is currently required from: Felix Singer, Tim Wawrzynczak, Angel Pons, Michael Niewöhner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/61211 )
Change subject: gma: Add `Tiger_Point` PCH ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/libgfxinit/+/61211/comment/0a965369_628c57ce PS1, Line 13: - TBT / Type-C
I haven't seen a PD controller that does lane muxing... […]
Ah, just learned TBT is much different (tunnels DP through its own link, it seems). Anyway, TGL has a lot more ports, yes. We'd need code for these no matter if they are used as HDMI/DP/Type-C/TBT. What I meant is that there shouldn't be much special about the different DP modes, but I was wrong, because TBT. But what the manual says is mostly three things: We need to do less for TBT (don't configure the PHY), we need to synchronize (manual mostly talks about power for the DP-Aux channel) and we have to query the number of available lanes. But the decision if our lanes get routed is still up to something else. So we just need to react to the circumstances, without any scary logic in libgfxinit.
-
Nico Huber (Code Review)